Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Construct the extension's GasFeeController through @metamask/wallet
instead of the local messenger-client-init wiring, integrating
MetaMask/core#9527.

The wallet now owns GasFeeController as an instanceOptions.gasFeeController
slot: it builds getProvider and getCurrentNetworkEIP1559Compatibility from
NetworkController itself and lets the controller default onNetworkDidChange
and getChainId via its messenger subscription. The extension supplies only
the client-specific overrides (interval, clientId, gas API endpoints, and
the BSC legacy gas API compatibility check).

- Add wallet-init/instance-options/gas-fee-controller.ts and a minimal
  wallet-init/messengers/gas-fee-controller-messenger.ts (delegates only
  NetworkController:getState + getNetworkClientById for the chain-id read).
- Wire gasFeeController into wallet-init/initialization.ts.
- Resolve this.gasFeeController via this.wallet.getInstance('GasFeeController')
  and drop the GasFeeControllerInit import + init-map entry.
- Delete the local confirmations/gas-fee-controller-init and
  messengers/gas-fee-controller-messenger (+tests) and their entries in
  messenger-client-init/messengers/index.ts. GasFeeController stays in
  controller-list.ts.

Preview-pin @metamask/wallet and @metamask/gas-fee-controller to the
core#9527 preview builds (7ed2770ae) until a wallet release ships it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Construct the extension's GasFeeController through @metamask/wallet
instead of the local messenger-client-init wiring, integrating
MetaMask/core#9527.

The wallet now owns GasFeeController as an instanceOptions.gasFeeController
slot: it builds getProvider and getCurrentNetworkEIP1559Compatibility from
NetworkController itself and lets the controller default onNetworkDidChange
and getChainId via its messenger subscription. The extension supplies only
the client-specific overrides (interval, clientId, gas API endpoints, and
the BSC legacy gas API compatibility check).

- Add wallet-init/instance-options/gas-fee-controller.ts and a minimal
  wallet-init/messengers/gas-fee-controller-messenger.ts (delegates only
  NetworkController:getState + getNetworkClientById for the chain-id read).
- Wire gasFeeController into wallet-init/initialization.ts.
- Resolve this.gasFeeController via this.wallet.getInstance('GasFeeController')
  and drop the GasFeeControllerInit import + init-map entry.
- Delete the local confirmations/gas-fee-controller-init and
  messengers/gas-fee-controller-messenger (+tests) and their entries in
  messenger-client-init/messengers/index.ts. GasFeeController stays in
  controller-list.ts.

Preview-pin @metamask/wallet and @metamask/gas-fee-controller to the
core#9527 preview builds (7ed2770ae) until a wallet release ships it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Construct the extension's GasFeeController through @metamask/wallet
instead of the local messenger-client-init wiring, integrating
MetaMask/core#9527.

The wallet now owns GasFeeController as an instanceOptions.gasFeeController
slot: it builds getProvider and getCurrentNetworkEIP1559Compatibility from
NetworkController itself and lets the controller default onNetworkDidChange
and getChainId via its messenger subscription. The extension supplies only
the client-specific overrides (interval, clientId, gas API endpoints, and
the BSC legacy gas API compatibility check).

- Add wallet-init/instance-options/gas-fee-controller.ts and a minimal
  wallet-init/messengers/gas-fee-controller-messenger.ts (delegates only
  NetworkController:getState + getNetworkClientById for the chain-id read).
- Wire gasFeeController into wallet-init/initialization.ts.
- Resolve this.gasFeeController via this.wallet.getInstance('GasFeeController')
  and drop the GasFeeControllerInit import + init-map entry.
- Delete the local confirmations/gas-fee-controller-init and
  messengers/gas-fee-controller-messenger (+tests) and their entries in
  messenger-client-init/messengers/index.ts. GasFeeController stays in
  controller-list.ts.

Preview-pin @metamask/wallet and @metamask/gas-fee-controller to the
core#9527 preview builds (7ed2770ae) until a wallet release ships it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Address review feedback on #9527:

- Make `instanceOptions.gasFeeController.clientId` required and drop the
  `'cli'` default, so every client (extension, mobile, wallet-cli) must
  identify itself to the gas API rather than silently inheriting a
  default. `gasFeeController` is now a required instance-options key
  (mirroring `networkController`); wallet-cli passes `clientId: 'cli'`
  explicitly.
- Throw a descriptive error naming the members of the cycle when
  `orderByDependencies` cannot satisfy the declared dependencies,
  instead of silently deferring to a later "handler not registered"
  messenger error.

Also re-add the `gas-fee-controller` instance rule via the new
programmatic `codeowners.ts` generator (#9529) picked up in the rebase
onto main.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…gnostic (MetaMask#9569)

## Explanation

The `GasFeeController` constructor was the only
currently-wired-or-wireable controller that performed **eager,
construction-time reads** of `NetworkController` and the network
provider:

- `new EthQuery(this.#getProvider())` — unconditional.
- Seeding `currentChainId` — either via an eager `getChainId()` call or
via `NetworkController:getState` + `getNetworkClientById`.

This forced any shared initialization (e.g. `@metamask/wallet`) to
guarantee `NetworkController` is constructed *before*
`GasFeeController`, which is exactly the construction-order coupling we
want to avoid. Every other order-agnostic controller resolves its
collaborators lazily.

This PR defers those reads to first use so the controller can be
constructed in any order, matching the pattern already used elsewhere.
**No public API change** — the constructor signature and
gas-fee-fetching behavior are unchanged.

## Changes

- Removed the eager `EthQuery` build and the eager `currentChainId`
seeding from the constructor. Network-change subscription wiring is kept
as-is (subscribing is safe regardless of construction order).
- Added lazy, memoized resolution:
- `#getEthQuery()` — builds the `EthQuery` from `getProvider` on first
use.
- `#getCurrentChainId()` — resolves the chain ID from the `getChainId`
callback when provided (only when paired with `onNetworkDidChange`,
preserving the original coupling), otherwise from `NetworkController`.
- `#onNetworkControllerDidChange` now resets `ethQuery` to `undefined`
(rebuilt lazily on the next fetch) instead of rebuilding it eagerly per
network change, and still updates `currentChainId`.

## Testing

- New tests assert construction performs **no**
`NetworkController:getState` / `getNetworkClientById` / `getProvider` /
`getChainId` calls — even when those handlers throw — for both the
callback and no-callback constructor branches.
- New test covers network-change handling via both the
`onNetworkDidChange` callback and the
`NetworkController:networkDidChange` messenger subscription (chain ID +
eth query update on the next fetch).
- All existing tests pass unchanged (53 total). 100% coverage on the
changed lines; remaining uncovered lines are pre-existing.

## References

Splits out the root-cause fix from the wiring PR MetaMask#9527, so that
`GasFeeController` can be migrated into the shared `@metamask/wallet`
init set without a dependency-ordering mechanism.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Touches core gas-estimation initialization and network-switch caching;
behavior is intended to stay the same but timing of first network reads
shifts to first fetch.
> 
> **Overview**
> **`GasFeeController` no longer touches `NetworkController` or the RPC
provider during construction**, so it can be instantiated before the
network stack is ready (e.g. shared `@metamask/wallet` init) without
changing the public constructor or fetch semantics.
> 
> The constructor drops eager `EthQuery` creation and immediate chain-ID
resolution (`getChainId()` / `getState` + `getNetworkClientById`).
Instead, **`#getEthQuery()`** and **`#getCurrentChainId()`** memoize
provider and chain ID on first use inside
**`_fetchGasFeeEstimateData`**. When **`onNetworkDidChange` +
`getChainId`** are supplied, the callback is stored without calling
`getChainId` at construct time.
> 
> On network change, **`#onNetworkControllerDidChange`** clears the
cached `ethQuery` (rebuilt on the next fetch) and still updates
`currentChainId` and polling. Tests lock in zero constructor-time
network/provider/`getChainId` calls and correct chain ID + provider
refresh after network switches via callback or
**`NetworkController:networkDidChange`**.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
66c249d. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>